[Developers] admb bug

Steve Martell SteveM at iphc.int
Mon Mar 10 12:09:19 PDT 2014


THanks Dave,

I'll incorporate the change, recompile and commit the code if it works.
S
On Mar 10, 2014, at 11:12 AM, dave fournier <davef at otter-rsch.com> wrote:

>
> I noticed that the subvector operator for dvectors does not
> check to see that the index bounds for the subvector are valid.
> This should fix the problem. code is in dvector.cpp
>
>
> dvector::dvector(_CONST predvector& pdv)
> {
>   shape=pdv.p->shape;
>   if (shape)
>   {
>     (shape->ncopies)++;
>   }
>   else
>   {
>     cerr << "Taking a subvector  of an unallocated dvector"<<endl;
>   }
>   v = pdv.p->v;
>   int mmin=pdv.p->indexmin();
>   int mmax=pdv.p->indexmax();
>   if (pdv.lb<mmin || pdv.ub> mmax)
>   {
>     cerr << "index out of bounds in dvector subvector operator" << endl;
>     ad_exit(1);
>   }
>   index_min=pdv.lb;
>   index_max=pdv.ub;
> }
>
> _______________________________________________
> Developers mailing list
> Developers at admb-project.org
> http://lists.admb-project.org/mailman/listinfo/developers


________________________________

This internet e-mail message, and any files transmitted with it, contains confidential, privileged information that is intended only for the addressee. If you have received this e-mail message in error, please call us at (206) 634-1838 collect if necessary) and ask to speak to the message sender. Nothing in this e-mail or the act of transmitting it, is to be construed as a waiver of any rights or privileges enjoyed by the sender or the International Pacific Halibut Commission pursuant to the International Organizations Immunities Act, 22 U.S.C. Sec. 288 et seq.


More information about the Developers mailing list