[ADMB Users] Fwd: Re: new version of R2admb on R-forge

[Johnoel Ancheta]

  Hi Ben,

Committed the changes suggested by Dave to the admb
version control.

Index: src/df1b2-separable/tpl2rem.lex
===================================================================
--- src/df1b2-separable/tpl2rem.lex    (revision 736)
+++ src/df1b2-separable/tpl2rem.lex    (working copy)
@@ -3942,8 +3942,17 @@

  #else
      strcpy(outcommand,"cat xxglobal.tmp   xxhtop.tmp   header.tmp "
-     "  xxalloc1.tmp   xxalloc2.tmp   xxalloc3.tmp   xxalloc4.tmp "
-     "   xxalloc5.tmp    xxtopm.tmp    xxalloc6.tmp > ");
+     "  xxalloc1.tmp   xxalloc2.tmp   xxalloc3.tmp ");
+    if (report_defined)
+    {
+      strcat(outcommand," xxalloc4.tmp");
+    }
+    if (preliminary_calcs_defined)
+    {
+      strcat(outcommand," xxalloc5.tmp");
+    }
+    strcat(outcommand, "  xxtopm.tmp    xxalloc6.tmp > ");
+
      strcpy(outcommand2,"cat tfile1  tfile2 tfile3 tfile4 > ");

      strcpy(outcommand3a,"sed -n -f ");


Johnoel

On 8/23/10 8:02 AM, John Sibert wrote:
> Can you please look into this and reply to Ben and the list?
>
> Thanks,
> John
>
> -------- Original Message --------
> Subject:     Re: [ADMB Users] new version of R2admb on R-forge
> Date:     Mon, 23 Aug 2010 12:27:45 -0400
> From:     Ben Bolker <bolker at ufl.edu>
> To:     davef at otter-rsch.com <davef at otter-rsch.com>
> CC:     users at admb-project.org <users at admb-project.org>, Motoki Wu 
> <apewu at ucdavis.edu>
>
>
>
>   Can this/has this gone in the 'official' source tree so it gets taken
> care of in the next release?
>
>   thanks,
>     Ben Bolker
>
> dave fournier wrote:
>>  Ben Bolker wrote:
>>
>>  OK in that case one can get rid of the erros reported in the liver 
>> gamma
>>  function by modifying the
>>  lex input file like this.
>>  get rid of
>>   /*
>>      strcpy(outcommand,"cat xxglobal.tmp   xxhtop.tmp   header.tmp "
>>       "  xxalloc1.tmp   xxalloc2.tmp   xxalloc3.tmp   xxalloc4.tmp"
>>       "   xxalloc5.tmp    xxtopm.tmp    xxalloc6.tmp>  ");
>>    */
>>  and change to
>>      strcpy(outcommand,"cat xxglobal.tmp   xxhtop.tmp   header.tmp "
>>       "  xxalloc1.tmp   xxalloc2.tmp   xxalloc3.tmp ");
>>      if (report_defined)
>>      {
>>        strcat(outcommand," xxalloc4.tmp");
>>      }
>>      if (preliminary_calcs_defined)
>>      {
>>        strcat(outcommand," xxalloc5.tmp");
>>      }
>>      This file is named remod10 on my version.  I can supply other
>>  detailas etc if required.
>>
>>
>>
>>>  dave fournier wrote:
>>>
>>>>  Ben Bolker wrote:
>>>>
>>>>  Well there is some confusion because it appears to me that Motoki was
>>>>  using  tpl2rem on simple.tpl
>>>>  which has no random effects.
>>>>  I say this because my  version of tpl2cpp does not produce any error
>>>>  message.
>>>>
>>>>  Once that is settled
>>>>  for  tpl2rem it would be simple modify the  cat ...  line to 
>>>> exclude the
>>>>  missing files.
>>>>
>>>>
>>>    It is already settled.
>>>    As I explained, Motoki's problem came about because R2admb 
>>> flagged the
>>>  warning message about 'safe mode' as an error (it no longer does).
>>>  Motoki got confused (I think) by the bit of code that was used to flag
>>>  the 'xxalloc' warnings and thought that was the problem with the code.
>>>    By default the current version of R2admb runs simple.tpl just fine,
>>>  with a warning message on some versions about 'safe' mode being
>>>  deprecated.  It filters xxalloc warnings.
>>>
>>>    cheers
>>>       Ben
>>>
>>>
>>>
>>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.admb-project.org/pipermail/users/attachments/20100823/941076d3/attachment.html>